[vtadmin] log response errors (#12844)

* log any error responses from the http api

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* also install grpc interceptors to log the grpc api

Signed-off-by: Andrew Mason <andrew@planetscale.com>

---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>

go/vt/vtadmin/grpcserver/server.go

@@ -17,6 +17,7 @@ limitations under the License.
 package grpcserver
 
 import (
+	"context"
 	"fmt"
 	"net"
 	"net/http"
@@ -118,6 +119,23 @@ func New(name string, opts Options) *Server {
 		unaryInterceptors = append(unaryInterceptors, otgrpc.UnaryServerInterceptor(otgrpc.WithTracer(tracer)))
 	}
 
+	streamInterceptors = append(streamInterceptors, func(srv interface{}, ss grpc.ServerStream, info *grpc.StreamServerInfo, handler grpc.StreamHandler) error {
+		err := handler(srv, ss)
+		if err != nil {
+			log.Errorf("%s error: %s", info.FullMethod, err)
+		}
+
+		return err
+	})
+	unaryInterceptors = append(unaryInterceptors, func(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (resp interface{}, err error) {
+		resp, err = handler(ctx, req)
+		if err != nil {
+			log.Errorf("%s error: %s", info.FullMethod, err)
+		}
+
+		return resp, err
+	})
+
 	recoveryHandler := grpc_recovery.WithRecoveryHandler(func(p any) (err error) {
 		return vterrors.Errorf(vtrpcpb.Code_INTERNAL, "panic triggered: %v", p)
 	})

go/vt/vtadmin/http/response.go

@@ -21,6 +21,7 @@ import (
 	"fmt"
 	"net/http"
 
+	"vitess.io/vitess/go/vt/log"
 	"vitess.io/vitess/go/vt/vtadmin/errors"
 )
 
@@ -44,6 +45,8 @@ type errorBody struct {
 // 500 unknown.
 func NewJSONResponse(value any, err error) *JSONResponse {
 	if err != nil {
+		log.Errorf(err.Error())
+
 		switch e := err.(type) {
 		case errors.TypedError:
 			return typedErrorJSONResponse(e)