-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Report: CreateShard allows shard names with "/", which breaks other commands/components #12842
Labels
Comments
ajm188
added
Type: Bug
Component: Cluster management
Component: VTAdmin
VTadmin interface
labels
Apr 5, 2023
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Apr 5, 2023
Fixes vitessio#12842. Signed-off-by: Andrew Mason <andrew@planetscale.com>
This was referenced Apr 5, 2023
deepthi
added a commit
that referenced
this issue
Apr 6, 2023
* Disallow the slash character in shard names Fixes #12842. Signed-off-by: Andrew Mason <andrew@planetscale.com> * add release note Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update go/vt/topo/shard.go Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> * Update changelog/17.0/17.0.0/summary.md Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> --------- Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <amason@hey.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
ajm188
pushed a commit
to planetscale/vitess
that referenced
this issue
Apr 6, 2023
* Disallow the slash character in shard names Fixes vitessio#12842. Signed-off-by: Andrew Mason <andrew@planetscale.com> * add release note Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update go/vt/topo/shard.go Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> * Update changelog/17.0/17.0.0/summary.md Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> --------- Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <amason@hey.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
deepthi
added a commit
that referenced
this issue
Apr 12, 2023
…12858) * [topo] Disallow the slash character in shard names (#12843) * Disallow the slash character in shard names Fixes #12842. Signed-off-by: Andrew Mason <andrew@planetscale.com> * add release note Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update go/vt/topo/shard.go Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> * Update changelog/17.0/17.0.0/summary.md Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Andrew Mason <amason@hey.com> --------- Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <amason@hey.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> * add changelog stub Signed-off-by: Andrew Mason <andrew@planetscale.com> * fix version name Signed-off-by: Andrew Mason <andrew@planetscale.com> --------- Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <amason@hey.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of the Issue
TopoServer's
CreateShard
does only minimal validation on the shard name; if you create a shard with a "/" character (e.g.commerce/a/b
), but without a "-" character, it is assumed to be non-range-based sharding and is therefore valid. other methods and commands will parse this as a keyspace with namecommerce
and a shard nameda/b
, which breaks those commands.Reproduction Steps
commerce/a/b
Binary Version
Operating System and Environment details
Log Fragments
No response
The text was updated successfully, but these errors were encountered: