Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scope): ✨ add option to always use new unsaved scope #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NetSkylz
Copy link

@NetSkylz NetSkylz commented Jun 3, 2023

Hello :)

Here is a small PR to add an option which bypass scope prompts and ask directly for a new unsaved scope each time.
This is handy in some cases, as if you use Jira ticket IDs as scopes in your commits.

Don't hesitate to give me feedback if needed, as it's my first contribution to a public project ! ;)

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Jun 3, 2023
@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Oops, The build workflow has failed! See in summary. 😥

@yi-Xu-0100
Copy link
Collaborator

👋 @NetSkylz, thanks for your PR! I think it is a good idea, but it seems to have some problem in workflow. Could you try to update code to fix it? 😁

@NetSkylz
Copy link
Author

NetSkylz commented Jun 3, 2023

Hello @yi-Xu-0100 !
From what I see, it's Typescript errors, but I get these already just after cloning the repo and opening it... From terminal, I clone the repo, go inside the folder and install packages. Then, I open the project and I see these errors even before touching anything. So I thought it was "normal".

But then, I'm unsure on how to fix it on my end without potentially breaking something, as it doesn't seem to be related to my code :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants