Use site configs in site #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
johnnyomair,
nsams and
thomasdax98
magdalenaxm
commented
Jul 5, 2024
johnnyomair
reviewed
Jul 10, 2024
thomasdax98
force-pushed
the
use-site-configs-in-site
branch
from
dfdf040
to
b44b43a
Compare
thomasdax98
reviewed
Jul 11, 2024
…a is needed later for not found page
thomasdax98
force-pushed
the
use-site-configs-in-site
branch
2 times, most recently
from
fb99d82
to
2f9c151
Compare
thomasdax98
force-pushed
the
use-site-configs-in-site
branch
2 times, most recently
from
303ddf6
to
3891531
Compare
johnnyomair
previously approved these changes
Jul 31, 2024
thomasdax98
force-pushed
the
use-site-configs-in-site
branch
from
9f76ef9
to
f15b3c1
Compare
johnnyomair
previously approved these changes
Jul 31, 2024
fraxachun
previously approved these changes
Jul 31, 2024
This was referenced Jul 31, 2024
Merged
nsams
reviewed
Aug 1, 2024
nsams
reviewed
Aug 1, 2024
nsams
reviewed
Aug 1, 2024
nsams
reviewed
Aug 1, 2024
nsams
reviewed
Aug 1, 2024
nsams
reviewed
Aug 2, 2024
nsams
approved these changes
Aug 2, 2024
nsams
reviewed
Aug 2, 2024
| } | ||
|
|
||
| // Used for getting SiteConfig in server-components where params is not available (e.g. sitemap, not-found - see https://github.com/vercel/next.js/discussions/43179) | ||
| export async function getSiteConfig() { |
There was a problem hiding this comment.
I'm not sure middleware is the right place for this function
There was a problem hiding this comment.
Me neither, but putting it in config.ts is not possible since this file is called from client components and therefore must not contain server libraries. What about an config.server.ts?
There was a problem hiding this comment.
I understand.
You could put it into it's own file?
thomasdax98
approved these changes
Aug 5, 2024
johnnyomair
pushed a commit
that referenced
this pull request
Aug 13, 2024
We need to change the icon path now that #283 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist