Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle assets-path correctly #362

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Handle assets-path correctly #362

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96eb9e6
Handle assets-path correctly
fraxachun Sep 16, 2024
5dcd4c6
Add comment
fraxachun Sep 18, 2024
a1dbef3
Merge remote-tracking branch 'origin/main' into assets-domain
fraxachun Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion site/src/util/siteConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ export function getHostByHeaders(headers: Headers) {
}

export function getSiteConfigForDomain(domain: string) {
const siteConfig = getSiteConfigs().find((siteConfig) => siteConfig.scope.domain === domain);
let siteConfig;
if (domain === "assets") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a comment here explaining why this if is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5dcd4c6

const host = getHostByHeaders(headers());
siteConfig = getSiteConfigs().find((siteConfig) => siteConfig.domains.main === host || siteConfig.domains.preliminary === host);
} else {
siteConfig = getSiteConfigs().find((siteConfig) => siteConfig.scope.domain === domain);
}
if (!siteConfig) throw new Error(`SiteConfig not found for domain ${domain}`);
return siteConfig;
}
Expand Down
Loading