[VIVO-1997] Log blank node deletion messages at DEBUG instead of WARN #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gneissone
requested changes
Jun 7, 2021
| log.warn("Deleting single triple with blank node: " + blankNodeModel); | ||
| log.warn("This likely indicates a problem; excessive data may be deleted."); | ||
| log.debug("Deleting single triple with blank node: " + blankNodeModel); | ||
| log.debug("This likely indicates a problem; excessive data may be deleted."); |
There was a problem hiding this comment.
Suggested change
| log.debug("This likely indicates a problem; excessive data may be deleted."); | |
| log.debug("This may indicate a problem; excessive data may be deleted."); |
Remove some of the doom and gloom if the warning is most likely to be triggered by normal operation.
gneissone
approved these changes
Jun 7, 2021
litvinovg
approved these changes
Jun 8, 2021
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2023
…#238) * Log blank node deletion messages at debug level instead of warn. * Switch to more informative debug message about blank node deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lyrasis.org/browse/VIVO-1997:
As part of the new "every-time" update of "first time" content, single-triple deletions with blank nodes occur and are innocuous. This pull request logs warnings related to this type of deletion at DEBUG so as not to litter the log with ominous-looking warnings during each startup with default settings.
How should this be tested?
Start Tomcat. Log should not show warnings related to blank node deletion.
Interested parties
@VIVO-project/vivo-committers