Online translation #241
Merged
Online translation #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Dec 24, 2021
There was a problem hiding this comment.
It works as described. However, I have added a couple of small comments. @litvinovg can you please check those comments before we merge this PR into the repository?
api/src/main/java/edu/cornell/mannlib/vitro/webapp/i18n/freemarker/I18nStringTemplateModel.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/i18n/I18nBundle.java
Outdated
Show resolved
Hide resolved
webapp/src/main/webapp/templates/freemarker/page/partials/developerPanel.ftl
Show resolved
Hide resolved
chenejac
approved these changes
Jan 10, 2022
ghost
approved these changes
Feb 19, 2022
ghost
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Online translation added to Developer panel settings * Added special characters conversion on file import and export for online translations * fix: Parse text nodes separately * fix: broken js on page prevents working developer panel * fix: workaround for online translations using freemarker template models * fix: safe way to convert array of objects to array of strings * fix: convert char codes on read/write property files * refact: corrected constant names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue VIVO-2002
What does this pull request do?
Adds option for VIVO and Vitro localization on website with downloading results in .properties file. This should simplify process of Vitro and VIVO interface translation.
What's new?
Added option to export translations with keys and arguments to HTML and parse HTML with javascripts to provide and interface for convinient translation of *.properties files in website context.
How should this be tested?
Enable online translation checkbox in Developer's panel
Try to translate VIVO or Vitro instance, download saved results (Export all), update properties files from Vitro and VIVO (Update file), import saved results from saved file and clean translations.
Interested parties
@VIVO-project/vivo-committers