Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for faux data property ranges #357

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

litvinovg
Copy link
Contributor

Fix for recent PR

What does this pull request do?

Fixes faux data property range options

What's new?

Create custom rdfs:literal range option as data property dao returns null for rdfs:literal uri.
Fixed untyped option label

How should this be tested?

A description of what steps someone could take to:

  • Create data property with range rdfs:Literal
  • Create faux data property (not error should appear on creation of faux data property)

Interested parties

@brianjlowe @chenejac @bkampe @VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link
Member

@brianjlowe brianjlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creation of the faux property succeeds.

@brianjlowe brianjlowe merged commit a7215cc into vivo-project:i18n-redesign Jan 24, 2023
ghost pushed a commit that referenced this pull request Feb 23, 2023
Co-authored-by: Georgy Litvinov <georgy.litvinov@tib.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants