VIVO-3751: Remove ICU4J dependency. #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used in a handful of places. The core java libraries provide the same functionality but with a less exchaustive locale database. The IBM ICU is more up to date than the Java version but is otherwise identical. see: https://unicode-org.github.io/icu/userguide/icu4j/#introduction-to-icu4j
kaladay
changed the title
ghost
mentioned this pull request
ghost
previously approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: vivo-project/VIVO#3751
What does this pull request do?
This ICU dependency is only used in a handful of places.
The core java libraries provide the same functionality but with a less exchaustive locale database.
The IBM ICU is more up to date than the Java version but is otherwise identical.
What's new?
com.ibm.icu.text.SimpleDateFormatwithjava.text.SimpleDateFormatcom.ibm.icu.text.Collatorwithjava.text.CollatorHow should this be tested?
A description of what steps someone could take to:
icu4jno longer appears.Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
IBM's ICU4J reference material:
Interested parties