Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if provided path is directory in translation converter #375

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Check if provided path is directory in translation converter #375

merged 1 commit into from
Mar 6, 2023
+5 −3

Conversation

litvinovg
Copy link
Contributor

What does this pull request do?

Check if provided path is directory in translation converter to prevent java.lang.IllegalArgumentException if there is no directory on the path.

How should this be tested?

  • Build vivo without /local/i18n directory
  • Verify that exception happend and Vitro|VIVO has started.

Interested parties

@chenejac

@litvinovg litvinovg added the rc label Mar 3, 2023
@chenejac chenejac merged commit c0b4851 into vivo-project:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenejac chenejac chenejac approved these changes

Assignees
No one assigned
Labels
rc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@litvinovg @chenejac