Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape html #388

Merged
merged 3 commits into from
May 9, 2023
Merged

Escape html #388

merged 3 commits into from
May 9, 2023

Conversation

litvinovg
Copy link
Contributor

@litvinovg litvinovg commented Apr 28, 2023

VIVO GitHub issue
VIVO PR

What does this pull request do?

Fixes some freemarker templates to avoid invalid html.

How should this be tested?

  1. Create data property with value </div>"</div>
  2. Open form to delete this data property. Form shouldn't be broken

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

This reverts commit cd825d7.
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg well done.

@chenejac chenejac linked an issue May 1, 2023 that may be closed by this pull request
@chenejac chenejac requested a review from milospp May 8, 2023 14:37
@chenejac chenejac removed the request for review from brianjlowe May 9, 2023 11:04
@chenejac chenejac merged commit 329b8e4 into vivo-project:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some freemarker templates don't have escaped values
3 participants