Make display authorization checks for each displayed object property statement #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
previously approved these changes
Mar 28, 2024
There was a problem hiding this comment.
@litvinovg well done
I have tested it by following instructions. No complaints for the code.
wwelling
reviewed
Mar 29, 2024
.../cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel.java
Outdated
Show resolved
Hide resolved
wwelling
reviewed
Mar 29, 2024
.../cornell/mannlib/vitro/webapp/web/templatemodels/individual/ObjectPropertyTemplateModel.java
Outdated
Show resolved
Hide resolved
… uncollated object property template models
litvinovg
force-pushed
the
display-statement-checks
branch
from
95f4b13
to
9640727
Compare
chenejac
approved these changes
Apr 4, 2024
wwelling
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Until now permission to display object property statement is only checked once for all statements of a property by using ?SOME_URI as a dummy object.
This PR adds authorization requests to check permissions for each property statement displayed on profile page.
What's new?
Added authorization requests for each object property statement displayed in profile in collated and uncollated object property template models.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers