Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow end date be equal to start date in Date time interval validator #453

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

litvinovg
Copy link
Contributor

VIVO GitHub issue

What does this pull request do?

Allows start date to be the same as end date in date time interval entry form.

What's new?

Allows start date to be the same as end date in date time interval entry form validator.

How should this be tested?

  • Reproduce the issue
  • Test that the pull request resolves the issue

Interested parties

@VIVO-project/vivo-committers

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg please check my comment

…ing/VTwo/DateTimeIntervalValidationVTwo.java

Co-authored-by: Dragan Ivanovic <chenejac@uns.ac.rs>
@litvinovg litvinovg requested a review from chenejac March 19, 2024 17:06
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks, the PR is fixing the linked issue

@chenejac chenejac merged commit 1ec8aa9 into vivo-project:main Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date time interval doesn't allow end date to be equal start date
2 participants