Replaced PlainGraph with GraphMem as a workaround for Jena plain grap… #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
force-pushed
the
remove-lang-string-literals
branch
from
8eff6f6
to
ee4db49
Compare
…h serialization bug.
litvinovg
force-pushed
the
remove-lang-string-literals
branch
from
ee4db49
to
b20920c
Compare
chenejac
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
General comment
@litvinovg thanks for this fix. I believe one reviewer might be enough for this PR.
Testing
I have reproduced the issue before application of this PR fix. Moreover, I tried to run tests you added before application of the fix (in BulkUpdatingModel and BulkUpdatingOntModel). All tests were failing.
After the application of fix, the issue is resolved and tests are passing.
Code reviewing
The method createPlainGraph in GraphFactory is not used anymore in the VIVO/Vitro codebase. I am wondering should we remove that method from the GraphFactory?
brianjlowe
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Fixes issue related to removing statements with language strings from configuration graphs.
What's new?
Replaced Graph implementation used in BulkUpdate models
How should this be tested?
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Java, Jena
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed