Avoid duplicate statements in CONSTRUCT query to improve perfomance #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
May 7, 2024
There was a problem hiding this comment.
General comment
Thanks for this. Well done.
Testing
I have reproduce the issue before applying fix in this PR, and verified it is fixed with this PR. Moreover, unit tests are passing.
Code reviewing
Please take a look into two my tiny comments regarding the code.
api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java
Outdated
Show resolved
Hide resolved
api/src/main/java/edu/cornell/mannlib/vitro/webapp/dao/jena/JenaModelUtils.java
Show resolved
Hide resolved
chenejac
approved these changes
May 7, 2024
brianjlowe
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
What does this pull request do?
Improved performance of removing statements with blank nodes.
What's new?
Removed duplicate lines from CONSTRUCT query
Added test
How should this be tested?
A description of what steps someone could take to:
Interested parties
@VIVO-project/vivo-committers
Related issue
vivo-project/VIVO#3871
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Java, Jena
Reviewers' report template
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed