Support user-specified CSS #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of patching the HTML files, the plugin creates its own stylesheet and passes it to EDoc using the `stylesheet` option. `github-markdown.css` and `prism.css` are imported from that generated CSS file. If the user specified his own stylesheet, we can now import it from that generated CSS file. This allows the user to provide his own CSS rules and even override the other stylesheets we import.
For whatever reason, `rebar3_format` completely bork the `generate_wrapping_css/2` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other words, the plugin now handles the
stylesheetoption inedoc_optsInstead of patching the HTML files, the plugin creates its own stylesheet and passes it to EDoc using the
stylesheetoption.github-markdown.cssandprism.cssare imported from that generated CSS file.If the user specified his own stylesheet, we can now import it from that generated CSS file. This allows the user to provide his own CSS rules and even override the other stylesheets we import.