Skip to content

Commit

Permalink
Fix changes for verbose name
Browse files Browse the repository at this point in the history
  • Loading branch information
TrangPham committed Apr 13, 2022
1 parent a1507ba commit 7ffed7a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion admin_confirm/templatetags/formatting.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ def format_change_data_field_value(field_value):

@register.simple_tag
def verbose_name(obj, fieldname):
return obj._meta.get_field(fieldname).verbose_name
if obj:
return obj._meta.get_field(fieldname).verbose_name
14 changes: 7 additions & 7 deletions docs/development_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,28 +65,28 @@ log('Message to send to stdout')

**Docker:**

Instead of local set-up, you can also use docker.
Instead of local set-up, you can also use docker. You may have to delete `.python-version` to do this.

Install docker-compose (or Docker Desktop which installs this for you)

```
docker-compose build
docker-compose up -d
docker-compose -f docker-compose.dev.yml build
docker-compose -f docker-compose.dev.yml up -d
```

You should now be able to see the app running on `localhost:8000`

If you haven't already done migrations and created a superuser, you'll want to do it here

```
docker-compose exec web tests/manage.py migrate
docker-compose exec web tests/manage.py createsuperuser
docker-compose -f docker-compose.dev.yml exec web tests/manage.py migrate
docker-compose -f docker-compose.dev.yml exec web tests/manage.py createsuperuser
```

Running tests in docker:

```
docker-compose exec -T web make test-all
docker-compose -f docker-compose.dev.yml exec -T web make test-all
```

The integration tests are set up within docker. I recommend running the integration tests only in docker.
Expand All @@ -100,7 +100,7 @@ Honestly this part is just for my reference. But who knows :) maybe we'll have a
Run tests, check coverage, check readme

```
docker-compose exec -T web make test-all
docker-compose -f docker-compose.dev.yml exec -T web make test-all
make check-readme
```

Expand Down

0 comments on commit 7ffed7a

Please sign in to comment.