Corrected camera index reading from config when multiple webcams #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed camera index reading from config
|
Thanks for noticing this. What was the "prefix" variable used for originaly? |
|
Didnt found it to be used anywhere. |
What?
|
|
I misunderstood you. I ment i didnt fount self.idx variable used except for setting video capture device number, which is originally always set to zero, and doesnt take into account webcam param in config. |
|
This is incorrect, The current code works correctly, though the changed index in the config only applies after a restart. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected camera index reading from config when multiple webcams
It was opening device index 0, regardless saved setting.