Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newer JSON-P & JSON-B standards as alternative to Jackson, fixes #29 #112

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jwgmeligmeyling
Copy link
Contributor

Initial implementation of #29. After approval of the overall structure, I will port the changes to the modules for Hibernate 5 and 4 too.

*
* @author Jan-Willem Gmelig Meyling
*/
public class JsonNodeBinaryType extends AbstractHibernateType<JsonValue> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is better named JsonValueBinaryType

* @author Vlad Mihalcea
* @author Jan-Willem Gmelig Meyling
*/
public class JsonbJsonSerializer implements JsonSerializer {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have these classes in the jsonb/util folder as they are specific to JSON processing only.

@vladmihalcea
Copy link
Owner

Looks very good. You should definitely consider porting it.

@jwgmeligmeyling
Copy link
Contributor Author

I’ll continue my work on the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants