More metrics #2302
Closed
More metrics #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WoosukKwon can you take a look |
NikolaBorisov
force-pushed
the
more-metrics
branch
from
7f25477
to
1a110a8
Compare
|
@simon-mo Can you take a look? |
Fix up the avg stats. Add more counters. Added total request, and tokens counters
NikolaBorisov
force-pushed
the
more-metrics
branch
from
1a110a8
to
a801543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some more metrics to Prometheus.
Total Number of requests
Total Number of input tokens
Total Number of output tokens
Avg time per output token
Max time per output token
Avg time per input token
Max time per input token
It is useful to have avg time per output token, in order to make sure server is generating at reasonable speed and the batch size is not too large