Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][test] exclude model download time in server start time #7834

Merged

Conversation

youkaichao
Copy link
Member

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao merged commit ea9fa16 into vllm-project:main Aug 24, 2024
18 of 21 checks passed
@youkaichao youkaichao deleted the fix_download_in_server_start branch August 24, 2024 08:03
@DarkLight1337
Copy link
Member

We should have ran entrypoints-tests before merging this. Since the model name is changed, test cases that check the model name now fail.

if not model.startswith("/"):
# download the model if it's not a local path
# to exclude the model download time from the server start time
model = snapshot_download(model)
Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot_download can download many more files than we need for inference, such as duplicate .pt files when we prefer to use safetensors. We should try to use a common function with how vLLM usually pulls down files for models

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you come up with a fix for it?

I don't know if safetensors would be enough. but we can have atry.

Copy link
Sponsor Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically I am proposing using DefaultModelLoader._prepare_weights

def _prepare_weights(self, model_name_or_path: str,

I can make a PR for this later today

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go ahead, I do see more files are downloaded in https://buildkite.com/vllm/fastcheck/builds/3094#01918525-98da-4596-8d31-f4e2c1172455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants