Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter #1534

Merged
merged 11 commits into from
May 31, 2023
Merged

Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter #1534

merged 11 commits into from
May 31, 2023

Commits on May 23, 2023

  1. Add some posixGroups to the openldap server for use in integration tests

    @cfryanr
    cfryanr committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e4dc810 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter 

    Add the field to the tmpl file and run codegen.
Also update the count of the fields of our APIs in an integration test.
    @cfryanr
    cfryanr committed May 25, 2023
    Configuration menu
    Copy the full SHA
    bad5e60 View commit details
    Browse the repository at this point in the history

  2. Use groupSearch.userAttributeForFilter during LDAP group searches 

    Load the setting in the controller.
Use the setting during authentication and during refreshes.
    @cfryanr
    cfryanr committed May 25, 2023
    Configuration menu
    Copy the full SHA
    c187474 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Add group search tests for UserAttributeForFilter in ldap_client_test.go

    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e3b7ba3 View commit details
    Browse the repository at this point in the history

  2. Add integration test for UserAttributeForFilter group search setting 

    Also adds new integration test env var to support the new test:
PINNIPED_TEST_LDAP_EXPECTED_DIRECT_POSIX_GROUPS_CN
    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    552ecea View commit details
    Browse the repository at this point in the history

  3. Add ActiveDirectoryIdentityProvider.spec.groupSearch.userAttributeFor… 

    …Filter

Add the field to the tmpl file and run codegen.
Also update the count of the fields of our APIs in an integration test.
    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0a1f966 View commit details
    Browse the repository at this point in the history

  4. Use groupSearch.userAttributeForFilter during ActiveDirectory group s… 

    …earches

- Load the setting in the controller.
- The LDAP auth code is shared between AD and LDAP,
  so no new changes there in this commit.
    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    600d002 View commit details
    Browse the repository at this point in the history

  5. Add integration test for AD UserAttributeForFilter group search setting

    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d4710cb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into ldap_userAttributeForFilter

    @joshuatcasey
    joshuatcasey authored May 31, 2023
    Configuration menu
    Copy the full SHA
    46178e9 View commit details
    Browse the repository at this point in the history

  7. Add docs for UserAttributeForFilter group search setting

    @cfryanr
    cfryanr committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d004859 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into ldap_userAttributeForFilter

    @cfryanr
    cfryanr authored May 31, 2023
    Configuration menu
    Copy the full SHA
    020e04b View commit details
    Browse the repository at this point in the history