Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line option. #1538

Merged
merged 3 commits into from
Jun 1, 2023
Merged

command line option. #1538

merged 3 commits into from
Jun 1, 2023

Conversation

smeet07
Copy link
Contributor

@smeet07 smeet07 commented May 30, 2023

Fixes #1512
Release note:


@smeet07
Copy link
Contributor Author

smeet07 commented Jun 1, 2023

@cfryanr should I add it https://pinniped.dev/docs/howto/install-concierge/ too? Also could you check the phrasing of the note?

Copy link
Member

@cfryanr cfryanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR!

In terms of adding it to https://pinniped.dev/docs/howto/install-concierge/, I see that page already starts with a link to the page that you edited in its first paragraph. Perhaps that is good enough? No need to change that page for now, in my opinion.

I've suggested some small changes to the paragraph that you added regarding the use of monospaced fonts.

Looking forward to merging this as soon as possible. Thanks again!

site/content/docs/reference/supported-clusters.md Outdated Show resolved Hide resolved
Co-authored-by: Ryan Richard <richardry@vmware.com>
@smeet07
Copy link
Contributor Author

smeet07 commented Jun 1, 2023

Thanks for submitting this PR!

In terms of adding it to https://pinniped.dev/docs/howto/install-concierge/, I see that page already starts with a link to the page that you edited in its first paragraph. Perhaps that is good enough? No need to change that page for now, in my opinion.

I've suggested some small changes to the paragraph that you added regarding the use of monospaced fonts.

Looking forward to merging this as soon as possible. Thanks again!

makes sense , not adding it to how to install concierge page.

@smeet07 smeet07 requested a review from cfryanr June 1, 2023 16:57
@cfryanr cfryanr merged commit 533c41f into vmware-tanzu:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants