Optionally use Contour in hack/prepare-supervisor-on-kind.sh #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1696 +/- ##
=======================================
Coverage 79.16% 79.16%
=======================================
Files 163 163
Lines 15767 15767
=======================================
Hits 12482 12482
Misses 2970 2970
Partials 315 315 |
cfryanr
commented
Sep 27, 2023
cfryanr
force-pushed
the
contour_in_hack_prepare_supervisor
branch
from
1ce6724
to
78cd040
Compare
joshuatcasey
approved these changes
Sep 27, 2023
cfryanr
force-pushed
the
contour_in_hack_prepare_supervisor
branch
from
78cd040
to
0e10549
Compare
Using Contour for ingress allows us to avoid using the hacky proxy server approach. This makes it easy to use any web browser to complete the login process, since there is no need to configure the proxy server for the browser.
cfryanr
force-pushed
the
contour_in_hack_prepare_supervisor
branch
from
0e10549
to
0ab6311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Contour for ingress allows us to avoid using the hacky proxy server approach. This makes it easy to use any web browser to complete the login process, since there is no need to configure the proxy server for the browser.
Example usage:
This PR does not make using Contour the default behavior of these scripts. You need to use the
PINNIPED_USE_CONTOURenvironment variable as shown above to ask for Contour. The integration tests do not use or depend on Contour, so it seems appropriate for the default behavior ofprepare-for-integration-tests.shto also not configure anything for Contour.This came about when I wanted to test logging in using Safari. It is very hard to configure Safari to use the local proxy server. This ended up being an easier solution.
Release note: