Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace version of google.golang.org/grpc #1807

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Dec 7, 2023

Replace the version of google.golang.org/grpc that is automatically selected as an indirect dep to be the same as the version explicitly mentioned in https://github.com/kubernetes/apiserver/blob/v0.28.4/go.mod#L40 which happens to be a version without any CVEs currently reported.

Release note:

NONE

Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e74b38) 79.12% compared to head (236a7cf) 79.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1807   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files         173      173           
  Lines       16176    16176           
=======================================
  Hits        12800    12800           
  Misses       3056     3056           
  Partials      320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr disabled auto-merge December 7, 2023 18:42
@cfryanr cfryanr merged commit cdd38dd into main Dec 7, 2023
40 checks passed
@cfryanr cfryanr deleted the replace_grpc_version branch December 7, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants