Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify error message for when there is no healthy controller manager #1922

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Apr 22, 2024

Clarify an error message as the result of this conversation: #1920

Release note:

NONE

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.62%. Comparing base (c79f8c8) to head (1d8310e).

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1922       +/-   ##
=========================================
+ Coverage      0   38.62%   +38.62%     
=========================================
  Files         0      349      +349     
  Lines         0    44511    +44511     
=========================================
+ Hits          0    17194    +17194     
- Misses        0    26801    +26801     
- Partials      0      516      +516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the original issue, seems like a reasonable change. 👍

@cfryanr cfryanr enabled auto-merge April 22, 2024 16:55
@cfryanr cfryanr merged commit 5fe94c4 into main Apr 22, 2024
43 checks passed
@cfryanr cfryanr deleted the clarify_err_msg branch April 22, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants