Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ptls to clarify the difference between FIPS and non-FIPS modes #1950

Merged
merged 1 commit into from
May 14, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented May 13, 2024

and backfill some basic tests

Release note:

NONE

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 95.60440% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.40%. Comparing base (f96cbea) to head (e13f4a7).

Files Patch % Lines
internal/crypto/ptls/profiles.go 96.66% 3 Missing ⚠️
internal/crypto/ptls/ptls.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
+ Coverage   29.39%   29.40%   +0.01%     
==========================================
  Files         349      348       -1     
  Lines       58484    58499      +15     
==========================================
+ Hits        17190    17201      +11     
- Misses      40780    40783       +3     
- Partials      514      515       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey merged commit b28e416 into main May 14, 2024
43 checks passed
@joshuatcasey joshuatcasey deleted the refactor_ptls branch May 14, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants