Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve remaining GitHub todos #1976

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented May 30, 2024

Release note:

NONE

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 49.63504% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 30.62%. Comparing base (38a90fa) to head (58b4ecc).
Report is 1 commits behind head on github_identity_provider.

Files Patch % Lines
test/testlib/browsertest/browsertest.go 0.00% 41 Missing ⚠️
...vedprovider/resolvedoidc/resolved_oidc_provider.go 4.54% 21 Missing ⚠️
...entityprovider/mockupstreamoidcidentityprovider.go 0.00% 3 Missing ⚠️
internal/upstreamldap/upstreamldap.go 75.00% 2 Missing ⚠️
...tiondomain/downstreamsession/downstream_session.go 0.00% 1 Missing ⚠️
...vedprovider/resolvedldap/resolved_ldap_provider.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           github_identity_provider    #1976      +/-   ##
============================================================
+ Coverage                     30.60%   30.62%   +0.01%     
============================================================
  Files                           362      363       +1     
  Lines                         60383    60461      +78     
============================================================
+ Hits                          18481    18515      +34     
- Misses                        41368    41411      +43     
- Partials                        534      535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr force-pushed the resolve_github_todos branch 2 times, most recently from aa77261 to 4d51748 Compare June 3, 2024 17:46
Also renamed an interface function from GetName to GetResourceName.

Co-authored-by: Ryan Richard <richardry@vmware.com>
@joshuatcasey joshuatcasey merged commit 8733a24 into github_identity_provider Jun 3, 2024
36 checks passed
@joshuatcasey joshuatcasey deleted the resolve_github_todos branch June 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants