Move ivd Astrolabe plugin into Velero Plugin for vSphere #386
Conversation
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
4cb0ae5
to
21438a7
Compare
|
Congratulations !! All the pre-check tests passed |
|
/hold We need to make sure this is thoroughly tested before merging. |
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
7e00ed1
to
85dd7e7
Compare
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
|
Congratulations !! All the pre-check tests passed |
|
Congratulations !! All the pre-check tests passed |
|
Congratulations !! All the pre-check tests passed |
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
|
rerun tests |
|
Congratulations !! All the pre-check tests passed |
|
@dsu-igeek How do we support astrolabe CLI now ivd is moved here? |
I'll add a CLI build here that uses the CLI library I put into Astrolabe and allows for additional plugins to be loaded. |
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
53257a1
to
7f45c03
Compare
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
7f45c03
to
b83bcd9
Compare
|
Congratulations !! All the pre-check tests passed |
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
b83bcd9
to
55f28e1
Compare
|
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
There was a problem hiding this comment.
Looks good to me. I am OK with this change as long as regression test get passed. BTW, would you please fill in the section of Does this PR introduce a user-facing change? with a changelog message even though it is not user facing? We use it to auto-generate changelog for releases.
Moved pkg/common/vsphere to velero-plugin-for-vsphere Updated ivd_protectd_entity_type_manager_test to use environment variable VC_URL for VC info Added vSphere specific astrolabe CLI vsphere-astrolabe Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
dsu-igeek
force-pushed
the
move-ivd-plugin-07-13-2021
branch
from
55f28e1
to
8c36b31
Compare
dsu-igeek
changed the title
|
WCP test run passed, results are here - https://container-dp.svc.eng.vmware.com/view/CNS-DP-WIP/job/TestWCP-2/814/consoleFull |
There was a problem hiding this comment.
Looks good. @dsu-igeek I updated the PR release note to be one-liner, which is expected by the release-notes tool.
|
Hi @dsu-igeek, how to use "vsphere-astrolabe" CLI? Does it take the same arguments as the original astrolabe CLI? |
Yes, it's exactly the same. Only difference is the ivd plugin is compiled into it and I'll be removing the ivd plugin from astrolabe proper so the Astrolabe version won't have ivd compiled into it. |
|
LGTM |
|
Congratulations !! All the pre-check tests passed |
…-tanzu#386) Moved pkg/common/vsphere to velero-plugin-for-vsphere Updated ivd_protectd_entity_type_manager_test to use environment variable VC_URL for VC info Added vSphere specific astrolabe CLI vsphere-astrolabe Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
What this PR does / why we need it:
Moves IVD (Improved Virtual Disk/First Class Disk) from astrolabe core into Velero Plug-in for vSphere
Does this PR introduce a user-facing change?: