-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on only container name while parsing feature flags #422
Conversation
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
LGTM |
Sorry, some of the pre-check tests are failing for this PR ! Please check the Jenkins job for more details |
/rerun |
rerun tests |
Congratulations !! All the pre-check tests passed |
…#422) The PR ensures that the plugin uses only the container name to determine velero container. Signed-off-by: Deepak Kinni <dkinni@vmware.com>
[Crossport]Rely on only container name while parsing feature flags (#422)
…#422) The PR ensures that the plugin uses only the container name to determine velero container. Signed-off-by: Deepak Kinni <dkinni@vmware.com>
What this PR does / why we need it:
The PR ensures that the plugin uses only the container name to determine
velero
container.Which issue(s) this PR fixes:
Fixes #421
Special notes for your reviewer:
Added 2 unit tests to emulate the scenario.
Does this PR introduce a user-facing change?:
Signed-off-by: Deepak Kinni dkinni@vmware.com