Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update velero-plugin-for-microsoft-azure to handle volumes created by the Azure CSI driver #4109

Closed
dsu-igeek opened this issue Sep 8, 2021 · 0 comments · Fixed by vmware-tanzu/velero-plugin-for-microsoft-azure#109
Closed

Update velero-plugin-for-microsoft-azure to handle volumes created by the Azure CSI driver #4109

dsu-igeek opened this issue Sep 8, 2021 · 0 comments · Fixed by vmware-tanzu/velero-plugin-for-microsoft-azure#109
Assignees
@ywk253100
Labels
Area/Cloud/Azure Area/Plugins Issues related to plugin infra/internal plugins
Milestone
v1.8.0

Comments

@dsu-igeek
Copy link
Contributor

dsu-igeek commented Sep 8, 2021 •
edited
Loading

Describe the problem/challenge you have
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, it looks straightforward to handle volumes created by the CSI driver with the existing VolumeSnapshotter.

We also need to handle and test with volumes migrated from the in-tree driver to the CSI driver.

Also look at how we would restore volumes that were provisioned with the in-tree driver and backed up but the destination cluster has been upgraded to the CSI driver.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "The project would be better with this feature added"
  • 👎 for "This feature will not enhance the project in a meaningful way"
@dsu-igeek dsu-igeek added P1 - Important Area/Cloud/Azure Area/Plugins Issues related to plugin infra/internal plugins labels Sep 8, 2021
@dsu-igeek dsu-igeek added this to the v1.8.0 milestone Sep 8, 2021
@dsu-igeek dsu-igeek changed the title Update velero-plugin-for-microsoft-azure to handle volume created by the Azure CSI driver Update velero-plugin-for-microsoft-azure to handle volumes created by the Azure CSI driver Sep 9, 2021
ywk253100 added a commit to ywk253100/velero-plugin-for-microsoft-azure that referenced this issue Nov 4, 2021
@ywk253100
Handle the volumes created by the CSI driver
2fcc88b 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@ywk253100 ywk253100 mentioned this issue Nov 4, 2021
Merged
ywk253100 added a commit to ywk253100/velero-plugin-for-microsoft-azure that referenced this issue Nov 16, 2021
@ywk253100
Handle the volumes created by the CSI driver
55cfe60 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero-plugin-for-microsoft-azure that referenced this issue Nov 16, 2021
@ywk253100
Handle the volumes created by the CSI driver
54d435b 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero-plugin-for-microsoft-azure that referenced this issue Nov 17, 2021
@ywk253100
Handle the volumes created by the CSI driver
3cf14b6 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@eleanor-millman eleanor-millman mentioned this issue Nov 17, 2021
Closed
zubron pushed a commit to vmware-tanzu/velero-plugin-for-microsoft-azure that referenced this issue Nov 19, 2021
@ywk253100
Handle the volumes created by the CSI driver (#109)
15330f9 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
yvespp pushed a commit to yvespp/velero-plugin-for-microsoft-azure that referenced this issue May 9, 2022
@ywk253100 @yvespp
Handle the volumes created by the CSI driver (vmware-tanzu#109)
8e7112e 
Current VolumeSnapshotter works with volumes allocated by the "in-tree" storage driver. Kubernetes is moving to the CSI driver for Azure and will deprecate the in-tree driver, however we may not be able to get CSI snapshots in Velero to GA before that happens. As an interim solution, we handle volumes created by the CSI driver with the existing VolumeSnapshotter.

Fixes vmware-tanzu/velero#4109

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywk253100 ywk253100

Labels
Area/Cloud/Azure Area/Plugins Issues related to plugin infra/internal plugins
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

Handle the volumes created by the CSI driver ywk253100/velero-plugin-for-microsoft-azure
3 participants
@dsu-igeek @ywk253100 @eleanor-millman