Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the restic package #5055

Closed
reasonerjt opened this issue Jun 28, 2022 · 1 comment · Fixed by #5143
Closed

Split the restic package #5055

reasonerjt opened this issue Jun 28, 2022 · 1 comment · Fixed by #5143
Assignees
@ywk253100
Labels
area/kopia-integration kind/refactor
Milestone
1.10

Comments

@reasonerjt
Copy link
Contributor

In the code of the package .../pkg/restic there are some generic code that should be used also by restic for example backupper.go repository_manager.go ....

We should consider split such files into another package, say .../pkg/podvolumes which then can reference .../pkg/restic and the new .../pkg/kopia to provide support for different repository backends.
@sseago
Copy link
Collaborator

sseago commented Jun 28, 2022

This makes a lot of sense. I don't know how much of the code is obvious from looking at it whether it's generic or not, or whether the easiest thing would be just to to wait until creating the new code path, at that point move things over that are needed in both places.

@reasonerjt reasonerjt added this to the 1.10 milestone Jun 29, 2022
@reasonerjt reasonerjt removed their assignment Jul 7, 2022
ywk253100 added a commit to ywk253100/velero that referenced this issue Jul 22, 2022
@ywk253100
Splic pkg/restic package
2da97e6 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@ywk253100 ywk253100 mentioned this issue Jul 22, 2022
Merged
3 tasks
ywk253100 added a commit to ywk253100/velero that referenced this issue Jul 22, 2022
@ywk253100
Splic pkg/restic package
75c3b5f 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jul 22, 2022
@ywk253100
Splic pkg/restic package
397776f 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jul 22, 2022
@ywk253100
Splic pkg/restic package
62d4542 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jul 29, 2022
@ywk253100
Splic pkg/restic package
a090212 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Aug 1, 2022
@ywk253100
Splic pkg/restic package
f3b2340 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Aug 5, 2022
@ywk253100
Splic pkg/restic package
8b556bc 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Aug 5, 2022
@ywk253100
Splic pkg/restic package
d4983b7 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Aug 5, 2022
@ywk253100
Splic pkg/restic package
13ba255 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit to ywk253100/velero that referenced this issue Aug 5, 2022
@ywk253100
Splic pkg/restic package
c98537e 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100 added a commit that referenced this issue Aug 5, 2022
@ywk253100
Splic pkg/restic package (#5143)
092fc01 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes #5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
danfengliu pushed a commit to danfengliu/velero that referenced this issue Sep 13, 2022
@ywk253100 @danfengliu
Splic pkg/restic package (vmware-tanzu#5143)
4f9792c 
This commit splits the pkg/restic package into several packages to support Kopia integration works

Fixes vmware-tanzu#5055

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywk253100 ywk253100

Labels
area/kopia-integration kind/refactor
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Split pkg/restic package ywk253100/velero
3 participants
@sseago @reasonerjt @ywk253100