🐛 Patch generated yaml for restore CRD as a hacky workaround #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think what's happening is that since "TCP" is the default, it should not be explicitly set, since it is implied. I looked at some other fields that have default values and they were not explicitly set. |
ashish-amarnath
force-pushed
the
k8s-1-18-crd-hack
branch
from
9643f28
to
e428841
Compare
|
@carlisia Per kubernetes/kubernetes#91395, though, if it's not set, there's another error. This seems to be confirming the second case mentioned in 91395. |
|
Cool. Would you mind please adding more context as documentation on hack/update-generated-crd-code.sh? Ideally the link to the issue would be used for reference if needed, but we wouldn't have to read the issue to figure out why we have this hack. What I'd like to see, is there a condition that would allow us to remove this script, what we would have to be on the lookout that would require extending that script if any, anything like that. |
ashish-amarnath
changed the title
Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ashish-amarnath
force-pushed
the
k8s-1-18-crd-hack
branch
from
e428841
to
2579d95
Compare
|
@carlisia added some context to the |
carlisia
approved these changes
Aug 12, 2020
ashish-amarnath
changed the title
nrb
approved these changes
Aug 12, 2020
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Dec 23, 2020
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
georgettica
pushed a commit
to georgettica/velero
that referenced
this pull request
Jan 26, 2021
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
vadasambar
pushed a commit
to vadasambar/velero
that referenced
this pull request
Feb 3, 2021
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
…tanzu#2814) * 🐛 Patch generated yaml for restore CRD as a hacky workaround Signed-off-by: Ashish Amarnath <ashisham@vmware.com> * changelog Signed-off-by: Ashish Amarnath <ashisham@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Amarnath ashisham@vmware.com
Fixes #2811