-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505
Convert Pod Volume Backup resource/controller to the Kubebuilder framework #3505
Conversation
/kind changelog-not-required |
b7e0fdf
to
a229524
Compare
This comment has been minimized.
This comment has been minimized.
@codegold79 I have some work to unblock things for our release, and also argh meetings, but will try to get this by EOD today. |
Also: I'm curious if you |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1def94a
to
0f040b5
Compare
from old way to Kubebuilder framwork. Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: Chris Schaefer <cschaefer@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
efc4943
to
67f79d4
Compare
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
Signed-off-by: F. Gold <fgold@vmware.com>
0257158
to
8bd5a30
Compare
…me-backup-controller-to-kubebuilder-framwork
Signed-off-by: F. Gold <fgold@vmware.com>
@dsu-igeek @zubron I have fixed the merge conflicts and ran |
I moved this PR to WIP because I'd like to fix the namespace issue detailed in #4052. |
…me-backup-controller-to-kubebuilder-framwork
Signed-off-by: F. Gold <fgold@vmware.com>
Added commit that will ensure that kubebuilder (controller-runtime) controllers will only act on resources that appear in their own namespace. See #4052 (comment) for more details. |
As we are evaulating using kubebuilder v3 to refactor the controllers, let's hold this PR as it's likely to be reworked. |
@codegold79 |
This PR was so behind, I created a new one that is based on the main branch. See PR #4436. |
Summary of change
Convert Pod Volume Backup resource/controller to the Kubebuilder framework. Write Ginkgo tests.
Fixes #3454
Please indicate you've done the following:
/kind changelog-not-required
.site/content/docs/main
.