Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'velero.io/exclude-from-backup' label string to const #5053

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

niulechuan
Copy link
Contributor

@niulechuan niulechuan commented Jun 28, 2022

Please add a summary of your change

Move 'velero.io/exclude-from-backup' label string to const

Does your change fix a particular issue?

None

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
@niulechuan
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 28, 2022
blackpiglet
blackpiglet previously approved these changes Jun 29, 2022
@blackpiglet blackpiglet requested review from ywk253100 and removed request for dsu-igeek June 29, 2022 12:42
@niulechuan niulechuan changed the title move 'velero.io/exclude-from-backup' label string to const Move 'velero.io/exclude-from-backup' label string to const Jun 30, 2022
Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
@niulechuan
Copy link
Contributor Author

Sorry, I should notice the change log is required.

@codecov-commenter
Copy link

Codecov Report

Merging #5053 (f17d763) into main (ec5503f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5053   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files         210      210           
  Lines       18439    18439           
=======================================
  Hits         7616     7616           
  Misses      10253    10253           
  Partials      570      570           
Impacted Files Coverage Δ
pkg/backup/item_backupper.go 78.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec5503f...f17d763. Read the comment docs.

@ywk253100 ywk253100 merged commit fb89747 into vmware-tanzu:main Jul 4, 2022
@niulechuan niulechuan deleted the use-const-in-map branch July 5, 2022 03:00
danfengliu pushed a commit to danfengliu/velero that referenced this pull request Sep 13, 2022
…nzu#5053)

* move 'velero.io/exclude-from-backup' label name to const

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>

* add changelog file (in changelogs/unreleased) of this PR

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-changelog kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants