Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeSnapshotLocation refactor with kubebuilder. #5148

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

blackpiglet
Copy link
Contributor

  1. modify VSL CRD API file name. Add kubebuilder related marker.
  2. Add Labels init code for VSL create command.

Signed-off-by: Xun Jiang jxun@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #5025

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

1. modify VSL CRD API file name. Add kubebuilder related marker.
2. Add Labels init code for VSL create command.

Signed-off-by: Xun Jiang <jxun@vmware.com>
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@reasonerjt reasonerjt merged commit 2b0d095 into vmware-tanzu:main Aug 1, 2022
@blackpiglet blackpiglet deleted the vsl-refactor branch October 15, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor VolumeSnapshotLocation CRD and related code with kubebuilder
4 participants