-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel downloadRequest when timeout without downloadURL #5329
Cancel downloadRequest when timeout without downloadURL #5329
Conversation
ce1b8d8
to
fe357ef
Compare
Codecov Report
@@ Coverage Diff @@
## main #5329 +/- ##
==========================================
- Coverage 40.88% 40.82% -0.07%
==========================================
Files 233 234 +1
Lines 20241 20260 +19
==========================================
- Hits 8276 8271 -5
- Misses 11364 11388 +24
Partials 601 601
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This code change LGTM |
e6821bc
to
045ba52
Compare
Updated PR description with test results. |
@reasonerjt all green now :D |
045ba52
to
a7d702c
Compare
added error "download request download url timeout, check velero server logs for errors. backup storage location may not be available" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @kaovilai !
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
a7d702c
to
2c759f3
Compare
An alternative implementation that we could do for newer/main would be to add error field to downloadRequestStatus and add a new phase error. |
Tested with
go install ./cmd/velero
Result takes about one minute to fail log command for a backup that no longer have backup storage location in the cluster. One minute default came from
velero/pkg/cmd/cli/backup/logs.go
Line 41 in 11bfe82
Thank you for contributing to Velero!
Please add a summary of your change
Cancel download request if timeout waiting for download URL
Does your change fix a particular issue?
Fixes #5324
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.