Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 5386 #5387

Merged
merged 1 commit into from
Sep 23, 2022
Merged

fix issue 5386 #5387

merged 1 commit into from
Sep 23, 2022

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue 5386: Velero providers a full URL as the S3Url while the underlying minio client only accept the host part of the URL as the endpoint and the schema should be specified separately.

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5387 (6c8981b) into main (66f6365) will decrease coverage by 0.03%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##             main    #5387      +/-   ##
==========================================
- Coverage   40.56%   40.52%   -0.04%     
==========================================
  Files         236      236              
  Lines       20385    20399      +14     
==========================================
- Hits         8269     8267       -2     
- Misses      11511    11525      +14     
- Partials      605      607       +2     
Impacted Files Coverage Δ
pkg/repository/provider/unified_repo.go 57.83% <76.92%> (+0.77%) ⬆️
pkg/repository/udmrepo/kopialib/backend/utils.go 70.73% <100.00%> (+0.73%) ⬆️
pkg/uploader/provider/kopia.go 52.84% <0.00%> (-4.07%) ⬇️
pkg/restore/restore.go 64.16% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qiuming-best qiuming-best merged commit 9b22ca6 into vmware-tanzu:main Sep 23, 2022
@Lyndon-Li Lyndon-Li deleted the issue-fix-5386 branch September 23, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants