Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved RIA execute input/output structs back to velero package #5441

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Oct 12, 2022

The RIA refactoring moved velero.RestoreItemAction into a separate (restoreitemaction) v1 package. Unfortunately, this change would require plugins to make code changes to locate the RestoreItemActionExecuteInput and RestoreItemActionExecuteOutput structs.

This commit restores those structs to the original velero package, leaving just the RestoreItemAction interface in the new v1 package.

Signed-off-by: Scott Seago sseago@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • [ x] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [ x] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

The RIA refactoring moved velero.RestoreItemAction into a separate
(restoreitemaction) v1 package. Unfortunately, this change would require
plugins to make code changes to locate the RestoreItemActionExecuteInput
and RestoreItemActionExecuteOutput structs.

This commit restores those structs to the original velero package, leaving
just the RestoreItemAction interface in the new v1 package.

Signed-off-by: Scott Seago <sseago@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5441 (45de8a7) into main (b5b4db2) will not change coverage.
The diff coverage is 81.63%.

@@           Coverage Diff           @@
##             main    #5441   +/-   ##
=======================================
  Coverage   40.62%   40.62%           
=======================================
  Files         236      236           
  Lines       20449    20449           
=======================================
  Hits         8308     8308           
  Misses      11532    11532           
  Partials      609      609           
Impacted Files Coverage Δ
pkg/plugin/framework/restore_item_action_client.go 0.00% <0.00%> (ø)
pkg/plugin/framework/restore_item_action_server.go 0.00% <0.00%> (ø)
pkg/restore/change_pvc_node_selector.go 67.46% <57.14%> (ø)
...g/restore/crd_v1_preserve_unknown_fields_action.go 32.20% <66.66%> (ø)
pkg/restore/restic_restore_action.go 75.24% <66.66%> (ø)
pkg/restore/admissionwebhook_config_action.go 61.36% <75.00%> (ø)
...reitemaction/v1/restartable_restore_item_action.go 82.50% <100.00%> (ø)
pkg/restore/add_pv_from_pvc_action.go 70.96% <100.00%> (ø)
pkg/restore/add_pvc_from_pod_action.go 67.85% <100.00%> (ø)
pkg/restore/apiservice_action.go 61.53% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet blackpiglet merged commit c0430b8 into vmware-tanzu:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants