Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pkg/cmd/cli package UT coverage. #6511

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Improve pkg/cmd/cli package UT coverage. #6511

merged 1 commit into from
Jul 18, 2023

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jul 17, 2023 •
edited
Loading

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 17, 2023
@blackpiglet blackpiglet marked this pull request as ready for review July 17, 2023 13:01
@blackpiglet blackpiglet marked this pull request as draft July 17, 2023 13:02
@blackpiglet blackpiglet force-pushed the improve_ut_coverage branch 5 times, most recently from 098f931 to ced3414 Compare July 18, 2023 03:35
@blackpiglet blackpiglet marked this pull request as ready for review July 18, 2023 03:46
@blackpiglet blackpiglet force-pushed the improve_ut_coverage branch 2 times, most recently from 9c411af to cd2050f Compare July 18, 2023 05:48
@blackpiglet
Copy link
Contributor Author

Not sure why the CodeCov report is not shown.
Put the upload URL in the Github action here:
https://app.codecov.io/github/vmware-tanzu/velero/commit/cd2050f120bc62d7b0ade7ca213f3d7ec94ef4e3

qiuming-best
qiuming-best previously approved these changes Jul 18, 2023
View reviewed changes
@blackpiglet blackpiglet changed the title Improve backup log command UT coverage. Improve pkg/cmd/cli package UT coverage. Jul 18, 2023
Improve backup log command UT coverage.
4a222b7 
Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet merged commit c4286d7 into vmware-tanzu:main Jul 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywk253100 ywk253100 ywk253100 approved these changes

@qiuming-best qiuming-best qiuming-best approved these changes

@reasonerjt reasonerjt Awaiting requested review from reasonerjt

Assignees

@blackpiglet blackpiglet

Labels
has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackpiglet @ywk253100 @qiuming-best