Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.13: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380) #7399

Merged

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Feb 6, 2024

  • Add BackupRepositories invalidation on BSL Create
    Simplify comments

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

  • Simplify

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com


Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@kaovilai kaovilai changed the title BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380) release-1.13: BackupRepositories associated with a BSL are invalidated when BSL is (re-)created. (#7380) Feb 6, 2024
…(re-)created. (vmware-tanzu#7380)

* Add BackupRepositories invalidation on BSL Create
Simplify comments

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

* Simplify

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

---------

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai marked this pull request as ready for review February 6, 2024 21:35
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5dd1d3b) 61.74% compared to head (62a5317) 61.73%.

Files Patch % Lines
pkg/controller/backup_repository_controller.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #7399      +/-   ##
================================================
- Coverage         61.74%   61.73%   -0.01%     
================================================
  Files               262      262              
  Lines             28433    28436       +3     
================================================
  Hits              17555    17555              
- Misses             9645     9648       +3     
  Partials           1233     1233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li merged commit 51a90e7 into vmware-tanzu:release-1.13 Feb 20, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants