Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for results of restore exec hook executions in Finalizing phase instead of InProgress phase #7619

Merged
merged 1 commit into from
Apr 16, 2024

Wait for results of restore exec hook executions in Finalizing phase …

2855225
Select commit
Loading
Failed to load commit list.
Merged

Wait for results of restore exec hook executions in Finalizing phase instead of InProgress phase #7619

Wait for results of restore exec hook executions in Finalizing phase …
2855225
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 16, 2024 in 0s

58.49% (+0.34%) compared to f3295cc

View this Pull Request on Codecov

58.49% (+0.34%) compared to f3295cc

Details

Codecov Report

Attention: Patch coverage is 82.99320% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 58.49%. Comparing base (f3295cc) to head (2855225).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/restore/restore.go 61.53% 10 Missing and 5 partials ⚠️
pkg/controller/restore_finalizer_controller.go 81.81% 4 Missing and 2 partials ⚠️
pkg/cmd/server/server.go 0.00% 3 Missing ⚠️
internal/hook/wait_exec_hook_handler.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7619      +/-   ##
==========================================
+ Coverage   58.15%   58.49%   +0.34%     
==========================================
  Files         343      343              
  Lines       35770    28457    -7313     
==========================================
- Hits        20801    16646    -4155     
+ Misses      13552    10392    -3160     
- Partials     1417     1419       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov