Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface errors when waiting for backupRepository #7762

Merged
merged 1 commit into from
May 17, 2024

Conversation

kaovilai
Copy link
Contributor

Make errors such as those found in #6928 (comment)

Makes errors easier to understand than "timed out waiting for the condition"

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@reasonerjt
Copy link
Contributor

reasonerjt commented May 6, 2024

Wouldn't Pollxxxx return the error returned by checkFunc ?
cc @Lyndon-Li

@kaovilai
Copy link
Contributor Author

kaovilai commented May 6, 2024

Removed the conditional check on err to always return err. See unit tests changes for updated error values.

@kaovilai kaovilai force-pushed the waitBackupRepoErrsVerbose branch from 9b55d40 to 5c2592d Compare May 7, 2024 03:40
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.66%. Comparing base (4d48273) to head (2c6853b).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7762      +/-   ##
==========================================
+ Coverage   58.64%   58.66%   +0.02%     
==========================================
  Files         344      344              
  Lines       28720    28735      +15     
==========================================
+ Hits        16843    16858      +15     
- Misses      10447    10448       +1     
+ Partials     1430     1429       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaovilai kaovilai force-pushed the waitBackupRepoErrsVerbose branch 3 times, most recently from 770b15e to e85d824 Compare May 9, 2024 19:36
Make errors such as those found in vmware-tanzu#6928 (comment)

Makes errors easier to understand than "timed out waiting for the condition"

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai kaovilai force-pushed the waitBackupRepoErrsVerbose branch from e85d824 to 2c6853b Compare May 9, 2024 21:20
@kaovilai kaovilai requested a review from Lyndon-Li May 10, 2024 02:31
@Lyndon-Li Lyndon-Li merged commit 65a831e into vmware-tanzu:main May 17, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants