Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Don't consider unschedulable pods unrecoverable #7926

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

sseago
Copy link
Collaborator

@sseago sseago commented Jun 25, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Don't consider "unschedulable" pods unrecoverable (for fast fail purposes), since pods will be briefly unschedulable while waiting for PV provisioning.

cherry-pick of #7899

Does your change fix a particular issue?

Fixes #7898

Please indicate you've done the following:

  • [x ] Accepted the DCO. Commits without the DCO will delay acceptance.
  • [x ] Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • [x ] Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Scott Seago <sseago@redhat.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.79%. Comparing base (2fc6300) to head (d21d413).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #7926      +/-   ##
================================================
- Coverage         58.80%   58.79%   -0.01%     
================================================
  Files               345      345              
  Lines             28771    28766       -5     
================================================
- Hits              16919    16914       -5     
  Misses            10423    10423              
  Partials           1429     1429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shubham-pampattiwar
Copy link
Collaborator

/lgtm

@Lyndon-Li Lyndon-Li merged commit 583cd8b into vmware-tanzu:release-1.14 Jun 26, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants