Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the VolumeHelper to third-party plugins. #7944

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jun 27, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7818

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 40.98361% with 36 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (5c413ec) to head (1fd959d).

Files Patch % Lines
internal/resourcepolicies/resource_policies.go 3.70% 26 Missing ⚠️
pkg/backup/actions/csi/pvc_action.go 53.84% 4 Missing and 2 partials ⚠️
pkg/controller/backup_controller.go 50.00% 1 Missing and 1 partial ⚠️
.../plugin/utils/volumehelper/volume_policy_helper.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.14    #7944      +/-   ##
================================================
+ Coverage         58.79%   58.80%   +0.01%     
================================================
  Files               345      346       +1     
  Lines             28766    28815      +49     
================================================
+ Hits              16914    16946      +32     
- Misses            10423    10438      +15     
- Partials           1429     1431       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet force-pushed the 7818_fix branch 2 times, most recently from 7927cb6 to 4a44f19 Compare July 1, 2024 05:46
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet blackpiglet merged commit 77b3c8f into vmware-tanzu:release-1.14 Jul 3, 2024
64 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants