-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset VolumeSnapshotRef in Backup Sync Flow #7983
Conversation
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
/kind changelog-not-required |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7983 +/- ##
==========================================
+ Coverage 58.77% 58.82% +0.05%
==========================================
Files 345 346 +1
Lines 28768 28854 +86
==========================================
+ Hits 16908 16973 +65
- Misses 10430 10449 +19
- Partials 1430 1432 +2 ☔ View full report in Codecov by Sentry. |
Namespace: "ns-" + string(snapCont.UID), | ||
Name: "name-" + string(snapCont.UID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this snapshot namespacedname supposed to be non-existing?
Can the string here be anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaovilai this is a copy paste from -https://github.com/vmware-tanzu/velero/blame/824bebbad7bc61077c6e80731468fb020d3dfd4f/pkg/util/csi/volume_snapshot.go#L641
My understanidng is that any name should work here.
We are creating a static VSC
1.14 cherry-pick: #8003 |
Reset VolumeSnapshotRef in Backup Sync Flow
Reset VolumeSnapshotRef in Backup Sync Flow
Thank you for contributing to Velero!
Please add a summary of your change
Follow on fix to #7924
Fixes: #7978
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.