Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oilshell renamed oil as ysh, but package still uses old name #51951

Open
sogaiu opened this issue Aug 23, 2024 · 7 comments · May be fixed by #52218
Open

Oilshell renamed oil as ysh, but package still uses old name #51951

sogaiu opened this issue Aug 23, 2024 · 7 comments · May be fixed by #52218
Labels
bug Something isn't working

Comments

@sogaiu
Copy link

sogaiu commented Aug 23, 2024

Is this a new report?

Yes

System Info

Void 6.6.47_1 x86_64 GenuineIntel uptodate FFFF

Package(s) Affected

oil-0.22.0_1

Does a report exist for this bug with the project's home (upstream) and/or another distro?

No response

Expected behaviour

Being able to invoke ysh successfully.

Actual behaviour

Attempting to invoke ysh leads to a message that ends ysh: command not found.

Steps to reproduce

  1. sudo xbps-install -Su
  2. sudo xbps-install -S oil # ...and answer appropriately until installation is complete
  3. ysh

Regarding the renaming, please see this.

@sogaiu sogaiu added bug Something isn't working needs-testing Testing a PR or reproducing an issue needed labels Aug 23, 2024
@classabbyamp
Copy link
Member

@bugcrazy

@tranzystorekk
Copy link
Contributor

tranzystorekk commented Aug 23, 2024

According to https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines we can migrate the package to the oils-for-unix version

@bugcrazy
Copy link
Contributor

I created this PR that renames the old names, ysh command, it had the old name oil, I also renamed the package name to oils, making things easier: #51964

@bugcrazy
Copy link
Contributor

According to https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines we can migrate the package to the oils-for-unix version

"The oils-for-unix tarball is the fast shell in C++, completed in 2024. The distro package should be called oils-for-unix."

Package currently uses CPython version, I changed the package name to oils, to make it easier, although the author does not recommend it, the oils-for-unix version is faster, but has bugs than the CPython version, as it was only completed this year, the CPython version is more tested and old.

@sogaiu
Copy link
Author

sogaiu commented Aug 24, 2024

Hmm, I assumed that folks who are interested in using the oilshell-related stuff at this point are more inclined to using the more recent release. At least that is the case for me -- the whole project is quite oriented toward testing and I think they'd appreciate getting feedback from users for their more recent efforts.

Just my two cents.

@icp1994
Copy link
Contributor

icp1994 commented Aug 24, 2024

I agree it makes more sense to build from the oils-for-unix-${version}.tar.gz - especially considering the instructions under 'Packaging' in https://www.oilshell.org/release/0.22.0

Also a new version was "tagged" yesterday upstream so could also incorporate the changes in an update PR.

@tranzystorekk tranzystorekk removed the needs-testing Testing a PR or reproducing an issue needed label Aug 24, 2024
@bugcrazy
Copy link
Contributor

bugcrazy commented Sep 1, 2024

Updated to version 0.23, waiting for merge!

@meator meator linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants