Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oils: renamed old names and update #51964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bugcrazy
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

srcpkgs/oils/template Outdated Show resolved Hide resolved
@bugcrazy bugcrazy force-pushed the patch-21 branch 2 times, most recently from ed38a9b to db3fb66 Compare August 26, 2024 09:48
@bugcrazy bugcrazy changed the title oils: renamed old names oils: renamed old names and update Aug 26, 2024
@leahneukirchen
Copy link
Member

So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

@bugcrazy
Copy link
Contributor Author

So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

The definition itself is confusing, as there are two packages, one Python and one C, we should adopt more logical standards, this oils standard for package, is more correct.

@leahneukirchen
Copy link
Member

leahneukirchen commented Sep 11, 2024

Okay, so this is the old Python-version, but there upstream says: https://www.oilshell.org/release/0.23.0/

The oil tarball is the slow reference interpreter based on CPython.

Don't rename old distro packages. They can remain oil.
It's not worth packaging oil in new distros. It may be removed at some point.

So let's keep this (just adding the link is fine), and perhaps someone can contribute oils-for-unix instead?

@bugcrazy
Copy link
Contributor Author

So, while we are renaming the package, should we do it like upstream suggests? https://github.com/oils-for-unix/oils/wiki/Oils-Packaging-Guidelines

The definition itself is confusing, as there are two packages, one Python and one C, we should adopt more logical standards, this oils standard for package, is more correct.

Okay, so this is the old Python-version, but there upstream says: https://www.oilshell.org/release/0.23.0/

The oil tarball is the slow reference interpreter based on CPython.
Don't rename old distro packages. They can remain oil.
It's not worth packaging oil in new distros. It may be removed at some point.

So let's keep this (just adding the link is fine), and perhaps someone can contribute oils-for-unix instead?

Python version is slow, a few seconds, C++ version is slower than bash version.

Python version is more stable and tested, has a history of having fewer bugs.

Here is a speed test and some bugs of the C++ version:

oils-for-unix/oils#1069

@ahesford
Copy link
Member

We don't need multiple versions of this package in Void, and the project author notes that the "reference" implementation might go away at some point, so just pick one to be the version packaged by Void.

@leahneukirchen
Copy link
Member

@ahesford doesnt matter, the new version should have a new package name anyway (and conflict, I guess)

@meator
Copy link
Contributor

meator commented Sep 14, 2024

and perhaps someone can contribute oils-for-unix instead?

I've tried to package oils-for-unix: #52218

@meator
Copy link
Contributor

meator commented Sep 14, 2024

Also, I vote for keeping oil as is and not renaming it to oils. This is what upstream recommends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants