-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add releaser CI scripts #217
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: 'Step 1: Prep Release' | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| version_spec: | ||
| description: 'New Version Specifier' | ||
| default: 'next' | ||
| required: false | ||
| branch: | ||
| description: 'The branch to target' | ||
| required: false | ||
| post_version_spec: | ||
| description: 'Post Version Specifier' | ||
| required: false | ||
| since: | ||
| description: 'Use PRs with activity since this date or git reference' | ||
| required: false | ||
| since_last_stable: | ||
| description: 'Use PRs with activity since the last stable git tag' | ||
| required: false | ||
| type: boolean | ||
| jobs: | ||
| prep_release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
|
|
||
| - name: Prep Release | ||
| id: prep-release | ||
| uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2 | ||
| with: | ||
| token: ${{ secrets.ADMIN_GITHUB_TOKEN }} | ||
| version_spec: ${{ github.event.inputs.version_spec }} | ||
| post_version_spec: ${{ github.event.inputs.post_version_spec }} | ||
| target: ${{ github.event.inputs.target }} | ||
| branch: ${{ github.event.inputs.branch }} | ||
| since: ${{ github.event.inputs.since }} | ||
| since_last_stable: ${{ github.event.inputs.since_last_stable }} | ||
|
|
||
| - name: '** Next Step **' | ||
| run: | | ||
| echo "Optional): Review Draft Release: ${{ steps.prep-release.outputs.release_url }}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| name: "Step 2: Publish Release" | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| branch: | ||
| description: "The target branch" | ||
| required: false | ||
| release_url: | ||
| description: "The URL of the draft GitHub release" | ||
| required: false | ||
| steps_to_skip: | ||
| description: "Comma separated list of steps to skip" | ||
| required: false | ||
|
|
||
| jobs: | ||
| publish_release: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| # This is useful if you want to use PyPI trusted publisher | ||
| # and NPM provenance | ||
| id-token: write | ||
| steps: | ||
| - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
|
|
||
| - name: Populate Release | ||
| id: populate-release | ||
| uses: jupyter-server/jupyter_releaser/.github/actions/populate-release@v2 | ||
| with: | ||
| token: ${{ secrets.ADMIN_GITHUB_TOKEN }} | ||
| branch: ${{ github.event.inputs.branch }} | ||
| release_url: ${{ github.event.inputs.release_url }} | ||
| steps_to_skip: ${{ github.event.inputs.steps_to_skip }} | ||
|
|
||
| - name: Finalize Release | ||
| id: finalize-release | ||
| env: | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| uses: jupyter-server/jupyter_releaser/.github/actions/finalize-release@v2 | ||
| with: | ||
| token: ${{ secrets.ADMIN_GITHUB_TOKEN }} | ||
| release_url: ${{ steps.populate-release.outputs.release_url }} | ||
|
|
||
| - name: "** Next Step **" | ||
| if: ${{ success() }} | ||
| run: | | ||
| echo "Verify the final release" | ||
| echo ${{ steps.finalize-release.outputs.release_url }} | ||
|
|
||
| - name: "** Failure Message **" | ||
| if: ${{ failure() }} | ||
| run: | | ||
| echo "Failed to Publish the Draft Release Url:" | ||
| echo ${{ steps.populate-release.outputs.release_url }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for pinning on a particular version?
Should there be a comment to explain why, when we look at it again in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JupyterLab 4.1 is breaking galata tests here and there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "breaking" mean? Is it snapshots mismatch? Galata runtime error? Something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Galata timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opted for a quick solution to unblock the release process, which we are quite late
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Maintaining the tooling around JupyterLab plugins can be painful, and it should not go in the way of getting things done.
Let's debug this separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thanks.
Would you mind posting more information about that "Galata timeout", here or in #220?
Wondering whether this should be fixed upstream in JupyterLab. I also noticed some changes related to the use of Galata downstream (for example in jupyterlite/jupyterlite#1263), so it could be useful to have this information somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the await calls to click on an element have the timeout error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping Galata to 5.1.0 fixes the issue