Merge pull request #2316 from lucming/del_parentheses

remove redundant parentheses
volcano-sh · Jul 1, 2022 · 8826496 · 8826496
2 parents 3b2bd6f + 8967e6b
commit 8826496
Showing 1 changed file with 15 additions and 17 deletions.
diff --git a/pkg/scheduler/plugins/predicates/predicates.go b/pkg/scheduler/plugins/predicates/predicates.go
@@ -305,26 +305,24 @@ func (pp *predicatesPlugin) OnSessionOpen(ssn *framework.Session) {
 		}
 
 		// Check PredicateWithCache
-		{
-			var err error
-			var fit bool
-			if predicate.cacheEnable {
-				fit, err = pCache.PredicateWithCache(node.Name, task.Pod)
-				if err != nil {
-					fit, err = predicateByStablefilter(task.Pod, nodeInfo)
-					pCache.UpdateCache(node.Name, task.Pod, fit)
-				} else {
-					if !fit {
-						err = fmt.Errorf("plugin equivalence cache predicates failed")
-					}
-				}
-			} else {
+		var err error
+		var fit bool
+		if predicate.cacheEnable {
+			fit, err = pCache.PredicateWithCache(node.Name, task.Pod)
+			if err != nil {
 				fit, err = predicateByStablefilter(task.Pod, nodeInfo)
+				pCache.UpdateCache(node.Name, task.Pod, fit)
+			} else {
+				if !fit {
+					err = fmt.Errorf("plugin equivalence cache predicates failed")
+				}
 			}
+		} else {
+			fit, err = predicateByStablefilter(task.Pod, nodeInfo)
+		}
 
-			if !fit {
-				return err
-			}
+		if !fit {
+			return err
 		}
 
 		// Check NodePorts